xiongyuxing/gongxue-base
1
0
Fork 0
forked from wangziqi/gongxue-base
Code Pull Requests Activity
Files
b0f7883f331b51d78c80656d4e2eb5cb97c94c85
gongxue-base/.superpowers/sdd/task-7-report.md
wangziqi 9b7a8e37b4 fix: resolve 5 review findings 
Critical 1: Remove broken '钉钉绑定' tab (IntegConfig) — deleted /rbac/user-ding-mappings calls
Critical 2: Fix decorator placement in CreateClassDto — @IsOptional @IsArray restored to teachers
Important 1: Restore sync.service.spec.ts from 1fa3363, strip importDingTalkUsers tests
Important 2: Fix N+1 in batchImportStudents — batched find/save with In() operator
Important 3: Add migrate-student-ding-mapping.sql
2026-07-09 17:25:44 +08:00

814 B
Raw Blame History

Task 7 — Cleanup test files

Sync service spec

  • apps/server/src/sync/sync.service.spec.ts was already deleted in commit 7b86918 (Task 4: remove importDingTalkUsers). No action needed.

Attendance service spec

  • apps/server/src/attendance/attendance.service.spec.ts already uses StudentDingMapping (lines 12, 42). No UserDingMapping references remain. Updated in commit ef1b46b.

Verification

  • npx tsc --noEmit in apps/server: 277 diagnostics, all pre-existing jest type errors (@types/jest not installed). Zero errors related to UserDingMapping or StudentDingMapping.
  • No files to commit — both targets are already clean.

Conclusion

Task complete with zero changes needed. Previous tasks (Task 4 entity rename, Task 2 import swap) already handled these test updates.