wangziqi/ruoyi-vue-pro
1
0
Fork 1
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
Files
79a57995023e2eda5d4b93e2acf7e70c08b696da
ruoyi-vue-pro/docs/education/migration/06-commit-review-0f846fd.md

2.4 KiB
Raw Blame History

Commit Review: 0f846fdaf5 (0f846fd), target repository

Phase 0 static assessment generated on 2026-07-29. No build, test, application startup, PostgreSQL connection, or Flyway migration was executed during this assessment.

Retain

  • TenantApiImpl public-service dependency, @PermitAll/@TenantIgnore pre-login route subject to security tests, and context derived from framework state rather than request tenant/user IDs.

Adjust

  • Retain TenantCommonApi/TenantApiImpl as a candidate generic lookup seam, but add contract tests and resolve DTO/null/serialization compatibility.
  • Replace unsupported default methods with abstract methods or a separate optional capability interface unless compatibility evidence requires them.
  • Make public resolution origin-binding, principal policy, port policy, and loginMethods ownership explicit.
  • Correct contradictory hostname documentation and test filter-chain/API behavior.

Replace

  • Unsupported default-method expansion with the selected interface design.

Remove by forward correction

  • Contradictory hostname/loginMethods documentation after policy decision.

Pending decisions

  • Public origin-binding versus intentionally public lookup.
  • Member-only context versus System/admin support.
  • Host-only versus authority-with-port identity.
  • Platform ownership of loginMethods and public error taxonomy.

Evidence

  • Verified /Users/tiku1/code/ruoyi-vue-pro/yudao-framework/yudao-common/src/main/java/cn/iocoder/yudao/framework/common/biz/system/tenant/TenantCommonApi.java:28-56.
  • Verified /Users/tiku1/code/ruoyi-vue-pro/yudao-framework/yudao-common/src/main/java/cn/iocoder/yudao/framework/common/biz/system/tenant/dto/TenantRespDTO.java:14-42.
  • Verified /Users/tiku1/code/ruoyi-vue-pro/yudao-module-system/src/main/java/cn/iocoder/yudao/module/system/api/tenant/TenantApiImpl.java:19-49.
  • Verified /Users/tiku1/code/ruoyi-vue-pro/yudao-module-education/src/main/java/cn/iocoder/yudao/module/education/controller/app/tenant/EducationTenantController.java:51-177 and /Users/tiku1/code/ruoyi-vue-pro/yudao-module-education/src/main/java/cn/iocoder/yudao/module/education/controller/app/EducationContextController.java:43-57.
  • Verified mismatch rejection in /Users/tiku1/code/ruoyi-vue-pro/yudao-framework/yudao-spring-boot-starter-biz-tenant/src/main/java/cn/iocoder/yudao/framework/tenant/core/security/TenantSecurityWebFilter.java:66-105.