codex/xyx #1

xiongyuxing · 2026-07-13T04:21:35Z

xiongyuxing commented

2026-07-13 04:21:35 +00:00

No description provided.

xiongyuxing added 2 commits 2026-07-13 04:21:36 +00:00

fix: use saved dingtalk config for integration calls 619b3b22bd

fix: improve error handling in expense form submissions 187e4f2af0

xiongyuxing added 2 commits 2026-07-13 06:29:59 +00:00

fix: enhance 401 error handling to exclude login requests 70283d9dfe

fix: enhance emergency contact phone display with masking and view option 6d42241918

xiongyuxing added 1 commit 2026-07-13 06:52:19 +00:00

fix: refactor notification display logic and add format function 910a4263f6

xiongyuxing added 1 commit 2026-07-13 07:27:26 +00:00

fix: remove sensitive data masking from student options label ebce2463f0

wangziqi requested changes 2026-07-13 07:34:10 +00:00

wangziqi left a comment

服务端测试回归，当前不建议合并。

在 PR 头提交 910a426 上运行：
npm run test -w apps/server -- --runInBand
结果为 3 个 test suite / 7 个 test 失败；同一命令在基线 b5ef91b 上是 46/46 suites、429 tests 全部通过。

问题集中在 apps/server/src/integration/dingtalk.service.ts:225-228：新的 token 缓存命中条件要求 accessTokenCredentialKey 与当前凭证一致，但现有 DingTalk 单测只预置 accessToken 和 tokenExpiresAt，导致缓存不再命中，测试中的首个业务 API mock 被误当成 access_token 响应。受影响的 suite：integration/dingtalk.service.spec.ts、attendance/dingtalk-attendance.service.spec.ts、integration/dingtalk.group-delete.spec.ts。

请更新这些缓存 token 测试桩（或改为显式 mock token 请求），并建议补充三类覆盖：数据库保存配置优先、数据库配置缺失时回退环境变量、凭证变化时刷新 token。修复后再合并。

服务端测试回归，当前不建议合并。在 PR 头提交 910a426 上运行： npm run test -w apps/server -- --runInBand 结果为 3 个 test suite / 7 个 test 失败；同一命令在基线 b5ef91b 上是 46/46 suites、429 tests 全部通过。问题集中在 apps/server/src/integration/dingtalk.service.ts:225-228：新的 token 缓存命中条件要求 accessTokenCredentialKey 与当前凭证一致，但现有 DingTalk 单测只预置 accessToken 和 tokenExpiresAt，导致缓存不再命中，测试中的首个业务 API mock 被误当成 access_token 响应。受影响的 suite：integration/dingtalk.service.spec.ts、attendance/dingtalk-attendance.service.spec.ts、integration/dingtalk.group-delete.spec.ts。请更新这些缓存 token 测试桩（或改为显式 mock token 请求），并建议补充三类覆盖：数据库保存配置优先、数据库配置缺失时回退环境变量、凭证变化时刷新 token。修复后再合并。

wangziqi closed this pull request

2026-07-13 07:40:33 +00:00

Pull request closed

This pull request cannot be reopened because the branch was deleted.

Sign in to join this conversation.

2 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: wangziqi/gongxue-base#1

Allow edits from maintainers