Commit Graph

5 Commits

Author SHA1 Message Date
b3655da012 fix: resolve 9 P0+P1 review findings (bills decorators, campus isolation bypass, ding raw crash, batch import counter, SSE multi-tab, interval leak, dept permissions, cycle prevention, tree depth) 2026-07-06 00:38:51 +08:00
9e6c136ef0 fix: apply code review fixes — double layout, SSE leaks, interval leak, conflict values
- App.tsx: remove double-wrapped MainLayout from /notifications route
- NotificationBell.tsx: decouple SSE from popover open state using ref
- useNotifications.ts: fix interval leak in onerror via ref in cleanup
- notifications.controller.ts: unsubscribe on req.on('close') for SSE Subject
- schedules.controller.ts: use existing schedule values in conflict catch
2026-07-05 23:31:21 +08:00
14a24a14b3 feat: add NotificationsController with SSE stream endpoint 2026-07-05 23:09:30 +08:00
ce36a92482 fix: revert untracked ExpenseType refs, fix findByUser falsy cursor check 2026-07-05 23:05:25 +08:00
5f14b9ff15 feat: add NotificationsService with SSE subject pool 2026-07-05 23:01:26 +08:00