xiongyuxing/gongxue-base
1
0
Fork 0
forked from wangziqi/gongxue-base
Code Pull Requests Activity
362 Commits 3 Branches 0 Tags
7bfd30b513779d6f22ae1bb61c7bfb2cfa906101
Commit Graph

177 Commits

Author SHA1 Message Date
xyx
ceb0e2bf14 fix: 添加默认床位生成逻辑并优化床位添加验证 2026-07-13 16:50:47 +08:00
wangziqi
f98c0ccaa8 refactor(rooms): remove dorm gender restrictions 2026-07-13 16:12:57 +08:00
wangziqi
aa1ed7db56 refactor: resolve remaining field audit issues 2026-07-13 16:12:57 +08:00
wangziqi
0533c30ece refactor(classes): preserve student membership history 2026-07-13 16:12:57 +08:00
wangziqi
1f32d1285b refactor(deposits): remove refund approval remnants 2026-07-13 16:12:56 +08:00
wangziqi
04ef5c42d9 refactor(deposits): remove inline installment creation 2026-07-13 16:12:22 +08:00
wangziqi
0515e6ed27 fix(integration): simplify manual DingTalk sync setup 2026-07-13 16:12:22 +08:00
wangziqi
effa34434b refactor(students): remove obsolete class id input 2026-07-13 16:12:22 +08:00
wangziqi
0377acd33b refactor: remove residual campus and department fields 2026-07-13 16:12:22 +08:00
wangziqi
6396d3e934 fix(schedules): support editable schedule notes 2026-07-13 16:12:21 +08:00
wangziqi
dfd3cf6772 fix(archive): align aggregate result field 2026-07-13 16:12:21 +08:00
wangziqi
2874ab7bee fix(occupancies): assign room resources during transfers 2026-07-13 16:12:21 +08:00
wangziqi
7860703672 test: update DingTalk token cache fixtures 2026-07-13 16:04:05 +08:00
xyx
910a4263f6 fix: refactor notification display logic and add format function 2026-07-13 14:52:03 +08:00
xyx
619b3b22bd fix: use saved dingtalk config for integration calls 2026-07-13 11:43:11 +08:00
wangziqi
b5ef91bf2d fix: support Windows dev startup 2026-07-13 10:35:43 +08:00
wangziqi
1c8bd08be4 feat: settle course attendance automatically 2026-07-13 10:26:38 +08:00
wangziqi
b9b295c997 refactor: remove unused classroom fields 2026-07-13 09:34:15 +08:00
wangziqi
a266d450e1 chore: apply eslint --fix autofixes (remove unnecessary as never casts in tests) 2026-07-12 23:01:37 +08:00
wangziqi
b5f4b8747c fix: schedules lookups test mock missing classroomRepo constructor arg 
The SchedulesService constructor expects 5 repository arguments.
The test only provided 4, passing {} as never for classroomRepo.
Added classroomRepo mock with find() returning full selected columns.

Fixes: schedules.lookups.spec.ts — 'returns scoped classes and
minimal classrooms for schedule viewers'
 2026-07-12 23:01:00 +08:00
wangziqi
cc4f4dae4e fix: audit remediation — SSE user scoping, FK transactional safety, UI error handling 
- H4: scoped SSE import progress to exact userId match; non-HTTP events excluded from all subscribers
- H2: moved PRAGMA foreign_key_check inside SQLite transaction before COMMIT; violations rollback preserving old tables
- M1: removed dead axios-style error branch from extractErrorMessage (interceptor already unwraps)
- M2: split handleSave try/catch — save errors vs reload errors shown distinctly
- M3: added provider field validation before AI config test request
- Added SSE scoping regression tests (import service + controller)
- Added FK check failure rollback test (database-migrations.spec)
- Updated controller spec expectations for userId parameter

Co-authored-by: Code Review <branch-review>
 2026-07-12 22:59:03 +08:00
wangziqi
b6fca99390 fix: align permission navigation and page access 2026-07-11 14:55:49 +08:00
wangziqi
1e1c476bc3 feat: add CASL authorization and AI configuration 2026-07-11 14:25:34 +08:00
wangziqi
8f0991a51f feat: replace tenants with organization management 2026-07-10 21:27:26 +08:00
wangziqi
8ed1682b90 fix permissions and teacher attendance workflows 2026-07-10 20:40:52 +08:00
wangziqi
44105c1689 refactor: remove obsolete scaffolding and dead modules 
Drop the unused root hello-world controller, empty CommonModule imports, development seeding code, legacy student report entity, stale DTOs, notification hook, and their placeholder tests.
 2026-07-10 14:12:56 +08:00
wangziqi
b093d69f6a fix(server): correct archive filters and deposit access 
Parse archived class query flags without Boolean string coercion, register the refund approval permission, and grant dorm managers the deposit permission group.
 2026-07-10 14:12:44 +08:00
wangziqi
e26a8e816e fix(attendance): normalize DingTalk match statuses 
Store and validate stable English status codes for unmatched, pending, and matched attendance records so import, filtering, and auto-match use the same values.
 2026-07-10 14:11:55 +08:00
wangziqi
1ca4a4d185 fix(archive): serve student attachments securely 
Download attachments through authenticated API requests, support configurable upload paths, validate resolved file locations, and retain compatibility with legacy stored paths.
 2026-07-10 14:11:47 +08:00
wangziqi
55881863c1 feat(sync): sync class schedules to DingTalk students 
Group active schedules by class, resolve enrolled students through DingTalk mappings, reuse shifts and attendance groups, and expose class-based sync status in the admin UI.
 2026-07-10 14:11:39 +08:00
wangziqi
f6a84fd6b3 fix: assign each user to single leaf dept to prevent duplicates 2026-07-10 10:09:47 +08:00
wangziqi
fb54a6c466 fix: assign users to leaf departments only, handle multi-branch dept chains 2026-07-10 10:08:07 +08:00
wangziqi
3ccb878092 fix: fetch users from all sub-departments in syncAll and fetchOrgTreeWithUsers 2026-07-10 10:06:35 +08:00
wangziqi
3992f6c33f feat: implement fetchOrgTree and fetchOrgTreeWithUsers via dingtalk API 2026-07-10 10:04:59 +08:00
wangziqi
31bcd15189 fix: use real name and phone from frontend when importing students 2026-07-10 09:50:18 +08:00
wangziqi
b261ec5930 feat: change dingUserIds to users array with name/mobile in DTOs 2026-07-10 09:49:41 +08:00
wangziqi
6029d8e2fd refactor(server): remove Department/UserDepartment entities, CampusScope, and departmentId from all entities 
- Delete department.entity.ts, user-department.entity.ts
- Remove Department/UserDepartment from entities/index.ts
- Remove departmentId column from 18 entities (AttendanceRecord, ArchiveAttachment, Bill, ClassSchedule, Classroom, ClassroomRental, Deposit, DepositInstallment, ExamScore, LearningRecord, Occupancy, PersonalExpense, ResultArchive, Room, RoomExpense, Student, StudentEnrollment, StudentProfile, StudentReport)
- Remove departments/ module entirely
- Delete campus-scope.ts, campus-scope.middleware.ts (request-utils.ts kept — it's just IP extraction)
- Simplify common.module.ts to empty module
- Remove CampusScopeMiddleware from app.module.ts
- Remove all CampusScope injections and filter calls across all services
- Remove departmentId from all DTOs and controllers
- Simplify dingtalk/wecom sync to only sync users (no dept table)
- Update seed module to remove department seeding
- Clean frontend compilation
 2026-07-09 17:51:32 +08:00
wangziqi
22bc1876d8 refactor: remove departmentId from Class entity 2026-07-09 17:32:37 +08:00
wangziqi
40fef906cd fix: resolve DingTalk dept ID to local department ID in class create 2026-07-09 17:28:12 +08:00
wangziqi
9b7a8e37b4 fix: resolve 5 review findings 
Critical 1: Remove broken '钉钉绑定' tab (IntegConfig) — deleted /rbac/user-ding-mappings calls
Critical 2: Fix decorator placement in CreateClassDto — @IsOptional @IsArray restored to teachers
Important 1: Restore sync.service.spec.ts from 1fa3363, strip importDingTalkUsers tests
Important 2: Fix N+1 in batchImportStudents — batched find/save with In() operator
Important 3: Add migrate-student-ding-mapping.sql
 2026-07-09 17:25:44 +08:00
wangziqi
91035e9f2c feat: add batch-import students to class endpoint 2026-07-09 17:12:23 +08:00
wangziqi
7b8691866e refactor: remove User-based import and RBAC UserDingMapping endpoints 2026-07-09 17:10:33 +08:00
wangziqi
570ef7b7e9 revert: remove deepest-2-levels filter, restore full org tree 2026-07-09 17:07:22 +08:00
wangziqi
e87e5e2096 refactor: syncAll creates Student + StudentDingMapping directly 2026-07-09 17:05:54 +08:00
wangziqi
73c1ea7a76 fix: correct studentId-as-userId bugs in 3 files 
- dingtalk.service.ts syncOneUser: find Student by userId before mapping,
  use Student.id (not User.id) as studentId FK
- sync.service.ts importDingTalkUsers: type coercion for studentId
  (method deleted in Task 4, minimal compile fix)
- schedule-sync.service.ts getStatus: remove broken teacher mapping
  query (teacher scheduling deprecated); hardcode mappedTeachers=0,
  totalTeachers=0
 2026-07-09 17:04:35 +08:00
wangziqi
86f126671c fix: repair 5 sites where StudentDingMapping.studentId was misused as User FK 
- dingtalk.service.ts syncOneUser: query studentRepo (not userRepo) by mapping.studentId
- sync.service.ts importDingTalkUsers: skip User role lookup for existing mappings
- attendance.service.ts autoMatchDingRecords: use studentId directly, remove second-hop query
- schedule-sync.service.ts syncAll: skip teacher mapping block (deprecated)
- rbac.service.ts getUnboundUsers: return [] (method deleted in Task 4)
 2026-07-09 17:00:00 +08:00
wangziqi
ef1b46b9f4 refactor: replace UserDingMapping with StudentDingMapping entity 2026-07-09 16:53:25 +08:00
wangziqi
4592502876 feat(sync): add import request/result logging 2026-07-09 16:32:02 +08:00
wangziqi
6b232eb4ed fix(seed): only seed with SEED_DEV=true, not auto on dev env 2026-07-09 16:32:01 +08:00
wangziqi
c56f297f95 refactor: remove SeedModule from app imports (manual seed only) 2026-07-09 16:32:01 +08:00