fix(admin): 前端功能与安全修复(角色勾选/月视图新建/附件预览/考勤 late 等)
由 OCR(open-codereview.ai,deepseek-v4-flash)审查驱动修复: - Roles 多组勾选、Schedules 月视图新建、useDirtyGuard 稳定引用 - JinshujuMatchModal success:false、Attendance store 订阅、EditableCell Enter、DynamicChart 空数据、渲染期 ref - AttachmentsTab 附件预览不再 window.open(防存储型 XSS)+ 请求乱序防护 - 考勤 late 计入出勤率与主状态 Reviewed-by: OCR (open-codereview.ai)
This commit is contained in:
@@ -1,5 +1,5 @@
|
||||
import React, { useState } from 'react';
|
||||
import { App, Button, Popconfirm, Space, Table, Upload } from 'antd';
|
||||
import React, { useRef, useState } from 'react';
|
||||
import { App, Button, Modal, Popconfirm, Space, Table, Upload } from 'antd';
|
||||
import type { ColumnsType } from 'antd/es/table';
|
||||
import { EyeOutlined, InboxOutlined, UploadOutlined } from '@ant-design/icons';
|
||||
import api from '../../api';
|
||||
@@ -10,6 +10,20 @@ import { getErrorMessage } from '../../utils/error';
|
||||
import { ATTACHMENT_CATEGORY_OPTIONS, formatFileSize } from './shared';
|
||||
import type { AttachmentRecord, TabProps } from './shared';
|
||||
|
||||
type AttachmentPreview = {
|
||||
url: string;
|
||||
name: string;
|
||||
kind: 'image' | 'pdf';
|
||||
};
|
||||
|
||||
/** 根据文件扩展名决定安全展示方式:图片/PDF 内联预览,其余一律下载 */
|
||||
function getAttachmentKind(fileName: string, mimeType?: string): 'image' | 'pdf' | 'download' {
|
||||
const ext = fileName.split('.').pop()?.toLowerCase() ?? '';
|
||||
if (['png', 'jpg', 'jpeg', 'webp', 'gif', 'bmp', 'svg'].includes(ext)) return 'image';
|
||||
if (ext === 'pdf' || mimeType === 'application/pdf') return 'pdf';
|
||||
return 'download';
|
||||
}
|
||||
|
||||
export const AttachmentsTab: React.FC<TabProps & { data: AttachmentRecord[] }> = ({
|
||||
data,
|
||||
studentId,
|
||||
@@ -18,6 +32,9 @@ export const AttachmentsTab: React.FC<TabProps & { data: AttachmentRecord[] }> =
|
||||
const { hasPermission } = usePermission();
|
||||
const canPurgeArchive = hasPermission('archive:purge');
|
||||
const [uploading, setUploading] = useState(false);
|
||||
const [preview, setPreview] = useState<AttachmentPreview | null>(null);
|
||||
// 预览请求序号:快速点不同行「查看」时,慢的旧响应回来直接丢弃,避免覆盖新预览
|
||||
const previewSeqRef = useRef(0);
|
||||
|
||||
const deleteAttachmentMutation = useApiMutation(
|
||||
async (attachmentId: number) => api.delete(`/archive/attachments/${attachmentId}`),
|
||||
@@ -33,6 +50,39 @@ export const AttachmentsTab: React.FC<TabProps & { data: AttachmentRecord[] }> =
|
||||
{ invalidate: [['archive', studentId]] },
|
||||
);
|
||||
|
||||
const closePreview = () => {
|
||||
previewSeqRef.current += 1; // 关闭后仍在途的旧响应也不再落地
|
||||
if (preview?.url) URL.revokeObjectURL(preview.url);
|
||||
setPreview(null);
|
||||
};
|
||||
|
||||
const openAttachment = async (record: AttachmentRecord) => {
|
||||
const seq = ++previewSeqRef.current;
|
||||
try {
|
||||
const blob = await api.get<Blob>(`/archive/${studentId}/attachments/${record.id}`, {
|
||||
responseType: 'blob',
|
||||
});
|
||||
if (seq !== previewSeqRef.current) return; // 已有更新的查看请求,丢弃本次慢响应
|
||||
const kind = getAttachmentKind(record.fileName, record.mimeType);
|
||||
const url = URL.createObjectURL(blob);
|
||||
if (kind === 'download') {
|
||||
// 非内联类型通过 download 属性触发下载,避免以页面同源打开可执行内容
|
||||
const a = document.createElement('a');
|
||||
a.href = url;
|
||||
a.download = record.fileName || 'attachment';
|
||||
document.body.appendChild(a);
|
||||
a.click();
|
||||
a.remove();
|
||||
window.setTimeout(() => URL.revokeObjectURL(url), 60_000);
|
||||
} else {
|
||||
if (preview?.url) URL.revokeObjectURL(preview.url);
|
||||
setPreview({ url, name: record.fileName || 'attachment', kind });
|
||||
}
|
||||
} catch (e: unknown) {
|
||||
message.error(getErrorMessage(e, '查看失败'));
|
||||
}
|
||||
};
|
||||
|
||||
const handleDelete = async (attachmentId: number) => {
|
||||
try {
|
||||
await deleteAttachmentMutation.mutateAsync(attachmentId);
|
||||
@@ -72,22 +122,7 @@ export const AttachmentsTab: React.FC<TabProps & { data: AttachmentRecord[] }> =
|
||||
title: '操作',
|
||||
render: (_: unknown, record: AttachmentRecord) => (
|
||||
<Space>
|
||||
<Button
|
||||
size="small"
|
||||
icon={<EyeOutlined />}
|
||||
onClick={async () => {
|
||||
try {
|
||||
const blob = await api.get<Blob>(`/archive/${studentId}/attachments/${record.id}`, {
|
||||
responseType: 'blob',
|
||||
});
|
||||
const url = URL.createObjectURL(blob);
|
||||
window.open(url, '_blank');
|
||||
setTimeout(() => URL.revokeObjectURL(url), 60_000);
|
||||
} catch (e: unknown) {
|
||||
message.error(getErrorMessage(e, '查看失败'));
|
||||
}
|
||||
}}
|
||||
>
|
||||
<Button size="small" icon={<EyeOutlined />} onClick={() => openAttachment(record)}>
|
||||
查看
|
||||
</Button>
|
||||
{hasPermission('student:edit') && record.status !== 'archived' ? (
|
||||
@@ -149,6 +184,25 @@ export const AttachmentsTab: React.FC<TabProps & { data: AttachmentRecord[] }> =
|
||||
}}
|
||||
style={{ marginTop: 16 }}
|
||||
/>
|
||||
<Modal
|
||||
title={preview?.name}
|
||||
open={!!preview}
|
||||
footer={null}
|
||||
onCancel={closePreview}
|
||||
width={preview?.kind === 'pdf' ? 900 : undefined}
|
||||
destroyOnHidden
|
||||
>
|
||||
{preview?.kind === 'image' ? (
|
||||
<img src={preview.url} alt={preview.name} style={{ width: '100%' }} />
|
||||
) : preview?.kind === 'pdf' ? (
|
||||
<iframe
|
||||
src={preview.url}
|
||||
title={preview.name}
|
||||
sandbox=""
|
||||
style={{ width: '100%', height: '70vh', border: 'none' }}
|
||||
/>
|
||||
) : null}
|
||||
</Modal>
|
||||
</div>
|
||||
);
|
||||
};
|
||||
|
||||
Reference in New Issue
Block a user